philc / philc/vimium

Minimum font size can break options UI

Open
#4,151 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
In the browser settings, if we change the "Minimum font size" to 16 or more, the "Restore" line of "Backup and Restore" section disappears off the screen.

I have poor vision, so I need to keep the font settings quite large.

I'm using Brave Browser, but this might affect other browsers too, especially Chrome-based browsers.

To Reproduce
Steps to reproduce the behavior:

  1. Under brave://settings/fonts, change "Minimum font size" to 18.
  2. Go to Vimium options (chrome-extension://dbepggeogbaibhgnhhndojpepiihcmeb/pages/options.html)
  3. Click on "Show Advanced Options" if the button is available.
  4. Click on "Click to download backup" at the bottom.
  5. Try to scroll down further to see how you can restore from the backup. The option for restoring is not visible anymore.
  6. Change "Minimum font size" to 15.
  7. The "Choose file" button for Restore is now visible.

image

Browser and Vimium version
chrome://version : 1.44.112 Chromium: 106.0.5249.119 (Official Build) (64-bit) OS: Linux
chrome://extensions : Version 1.67.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from chrome-extension://dbepggeogbaibhgnhhndojpepiihcmeb/pages/options.html using a minimum font size of 18, then inspect the options page's Backup and Restore UI. Verify the restore controls remain reachable and visible at the reported font sizes, while preserving the existing behavior at smaller sizes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.