philc / philc/vimium

Unexpected behavior of Vimium with closed custom elements

Open
#4,112 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

In normal textarea and textarea in open custom elements (attachShadow({ mode: "open" })), shortcuts defined in Vimium are disabled and I can input these keys. However, in textarea in closed custom elements (attachShadow({ mode: "closed" })), shortcuts are handled by Vimium and I cannot input these keys.

Expected:

I can input keys defined as shortcuts to textarea in closed custom elements.

To Reproduce

Here is a reproduction code.
https://github.com/mono0x/vimium-closed-custom-element-example

Browser and Vimium version

  • Microsoft Edge 104.0.1293.54 and Vimium 1.67
  • Google Chrome 104.0.5112.102 and Vimium 1.67

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the linked reproduction in Chrome or Edge and compare keyboard handling in normal textareas, open shadow roots, and closed shadow roots. Trace the existing Vimium shortcut handling around those cases; done means shortcut keys remain inputtable in textareas inside closed custom elements without changing the existing behavior for normal or open elements.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.