philc / philc/vimium

`f`(open a link in the current tab)+Shift mode not open in new tab for j-novel book headers

Open
#4,098 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
normally when using f plus shift, it open the selected link in a new tab rather than the current tab, but for the book headers in j-novel, this somehow does not work

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://j-novel.club/series
  2. press f (after everything has loaded)
  3. push the key for the book header (in the screenshot M) while also pressing down on SHIFT

Example of a book header on j-novel (while having f mode activated):
1

Browser and Vimium version
firefox 103.0 linux (manjaro)
vimium 1.67.1
OS: Linux 5.18.14-1-MANJARO #1 SMP PREEMPT_DYNAMIC Sun Jul 24 09:00:58 UTC 2022


PS: middle-mouse-button click works, but CTRL+Click does not

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the j-novel.club series page using Vimium's f mode and Shift, comparing book headers with links that work correctly. Trace the link-hint handling for Shift or new-tab activation; done means book-header links open in a new tab consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.