philc / philc/vimium

Next/previous page key not working for certain webcomics

Open
#4,090 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

[Disclaimer: Probably not an actual bug, more like a cry for help.]

Describe the bug
I use the [[ and ]] bindings a lot when reading web comics, they're an awesome feature! ❤️

However, for this one webcomic, Order of the Stick it doesn't work for me. The buttons for previous/next have both alt text and title "Previous Comic," respectively "Next Comic," and I've tried adding those strings to the Previous/Next patterns but it hasn't help.

To Reproduce
Steps to reproduce the behavior:

  1. Go to URL 'https://www.giantitp.com/comics/oots1261.html'
  2. Type ]] or [[, the former doesn't do anything, the latter seems to click "News."

Settings I tried:

Previous patterns: prev,previous,back,older,<,‹,←,«,≪,<<,Previous Comic
Next patterns: next,forward,more,newer,>,›,→,»,≫,>>,Next Comic

Browser and Vimium version

   Name  Firefox
Version  102.0.1
     OS  Darwin 17.7.0 Darwin Kernel Version 17.7.0: Fri Oct 30 13:34:27 PDT 2020; root:xnu-4570.71.82.8~1/RELEASE_X86_64

Vimium 1.67.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue at the Order of the Stick URL with the configured [[ and ]] bindings, then trace how Vimium identifies previous and next links using their alt text and title. Done means both bindings activate the comic's corresponding links without selecting the News link, with the behavior verified on the reported page.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.