philc / philc/vimium

Pagination does not always occur with the active window

Open
#4,066 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Pagination does not always occur with the active window (document.activeelement).

Include a screenshot if applicable.
animated gif

To Reproduce
Steps to reproduce the behavior:

  1. Go to URL 'https://www.nytimes.com/2022/05/31/us/america-grief-life.html'
  2. Using Vimium, click on 'Read Comments' (at bottom of article)
  3. Using Vimium, click on 'Reader Picks'
  4. Using Vimium, scroll page up / down.
  5. Notice it is the underlying article that is scrolled, and not the comments itself.

Browser and Vimium version
Chrome browser
Vimium version 1.67

If you're using Chrome, include the Chrome and OS version found at chrome://version. Also include the Vimium version found at chrome://extensions.

Google Chrome 102.0.5005.61 (Official Build) (arm64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 12.4 (Build 21F79)
JavaScript V8 10.2.154.4
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.61 Safari/537.36

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue at the linked New York Times article in Chrome with Vimium, following the listed Vimium steps and observing document.activeElement while scrolling. Trace the pagination and active-window behavior involved in the comments view. Done means scrolling after selecting Reader Picks moves the comments rather than the underlying article, with the behavior verified in the reported scenario.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.