philc / philc/vimium

Dvorak find links are unreadable

Open
#4,027 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When using find links with dvorak keys, the keys are unreadable, especially , vs . vs ' given that the text shown is so small.

To Reproduce
Steps to reproduce the behavior:

  1. Set config "characters used for link hints" to aoeu',.p;qjk
  2. Press f
  3. See the screenshot
    image

Include a screenshot if applicable.

Browser and Vimium version 98.0.1 arch linux Linux 5.16.14-zen1-1-zen #1 ZEN SMP PREEMPT Fri, 11 Mar 2022 17:40:33 +0000 and 1.67.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing find links with the reported Dvorak character configuration and compare the rendered labels with the attached screenshot. Trace the find-link rendering entry point and determine what change would make punctuation characters distinguishable; done means the configured labels are readable when pressing f.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.