philc / philc/vimium

Visually indicate omnibar will open in new tab and not the current one

Open
#4,020 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

I often press O so quickly, that sometimes the Shift is not being recognized and thus it actually presses o. But because of lack of visual feedback I can't find out until I approve the content of omnibar.

I envision there is a visual difference between O omnibar (open in new tab) and o omnibar (open in the current tab) by default (i.e. without hacking anything nor writing own CSS styles in Vimium settings).

To Reproduce

Steps to reproduce the behavior:

  1. turn your back to your PC
  2. tell your spouse to press either o or Shift + o not telling you which one she pressed
  3. turn back to your PC and tell your spouse whether it'll open in the current or new tab

Browser and Vimium version

Firefox 96.0.3
Vimium 1.67.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior in Vimium on Firefox with o and O, then locate the omnibar UI entry point and its styling. The change is complete when the two commands have visibly distinct default states before approval, without custom CSS, and the existing omnibar behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.