Options not saving on Firefox
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
The Vimium options are not saving. Pressing Ctrl-Enter, or clicking Save Changes does nothing.
To Reproduce
Steps to reproduce the behavior:
- Go to URL you want to exclude (e.g. jupyter-lab, so http://localhost:8889)
- Click on the Vimium icon
- Click 'Add Rule'
- EIther leave keys empty or type star
- Click Save Changes or typing Ctrl-Enter does nothing.
Alterantively, attempting to do this from the options page is also unsuccessful (see screenshot) - the boxes don't even appear to enter a URL and key.
Vimium: 1.67.1
Firefox 97.0
20220202182137
canonical
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:97.0) Gecko/20100101 Firefox/97.0
Linux 5.13.0-28-generic #31-Ubuntu SMP Thu Jan 13 17:41:06 UTC 2022
Yaru-dark / Yaru
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure in Firefox 97 from the Vimium popup and options page, following the listed steps for adding an exclusion rule. Trace the save action and compare it with the successful path in another supported browser; done means a rule can be entered, saved, and remains present after reopening the options.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100