philc / philc/vimium

Firefox option swaps foreground / background tab commands

Open
#3,991 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I have this option set since ages and only experienced the incorrect Vimium behavior since the extension update.

@xstnztk It's because old versions of Vimium "simulates" OpenInNewTab and so on, so it didn't trigger the Firefox's built-in process which considers about the option.

This is a new issue: do we need a new command option for LinkHints.* to swap the ctrl and ctrl+shift sent by Vimium?

Originally posted by @gdh1995 in https://github.com/philc/vimium/issues/3964#issuecomment-1019093547

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the LinkHints.* command handling and the existing foreground/background tab command behavior described in the issue. Reproduce the Firefox option that swaps those behaviors, then determine whether the command handling can support the proposed Ctrl and Ctrl+Shift mapping. Done means the commands follow the Firefox preference without breaking their default behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.