philc / philc/vimium

Scrolling does not stop on key release with smooth scrolling on.

Open
#3,984 9 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
With smooth scrolling enabled, if I scroll down with j and back up with k, it doesn't stop until it reaches the top of the page. Not a keyboard issue as I checked with on-screen keystroke display if it registers but it doesn't. The behaviour is as expected with smooth scrolling turned off but the result is choppy. This does not trigger always but occasionally.

To Reproduce
Steps to reproduce the behavior:

  1. Go to URL 'any random google search'
  2. Click on 'j to scroll down then go back up with k'

Include a screenshot if applicable.

Browser and Vimium version

If you're using Chrome, include the Chrome and OSS version found at chrome://version. Also include the Vimium version found at chrome://extensions.

Google Chrome | 97.0.4692.71 (Official Build) (64-bit)
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Linux
JavaScript | V8 9.7.106.18

If you're using Firefox, report the Firefox and OS version found at about:support. Also include the Vimium version found at about:addons.

Vimium version 1.67

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Vimium 1.67 with Chrome 97 on Linux, using smooth scrolling and the j/k keys on a search-results page. Compare behavior with smooth scrolling disabled; done means scrolling stops when the key is released or the direction changes, without continuing to the top.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.