Vimium isn't disabled in cross-origin subframes of excluded documents.
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Vimium isn't disabled in cross-origin subframes of excluded documents.
To Reproduce
- Add
https://developer.mozilla.org/*to the exclude list in Vimium options. - Go to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe. Type i (or ?, or anything else to test if Vimium is enabled). Notice that Vimium isn't enabled, which is as expected.
- Focus either of the iframes in the first demo (both the container and the map are embedded on different sites, so either works).
- Type i and notice that Vimium is still enabled in the frame.
Browser and Vimium version
Firefox 96.0a1, but this reproduces in both Firefox and Chrome. Vimium 1.67.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue using the Vimium exclude list and the MDN iframe example in both Firefox and Chrome. Trace how excluded documents are handled when focus moves into a cross-origin subframe, then verify that Vimium remains disabled in those frames without changing behavior for included documents.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100