Firefox: some website links trigger the popup blocker
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
When using vimium, there are 'some' websites which trigger the popup blocker. I'm providing all the information I have here, but don't have the knowledge to differentiate what's special about this site in particular.
For clarity, the website in question is a Malaysian website which allows you to earn some cash out of the referral rewards given when purchasing at online retail sites. Accounts are free but require some personally-identifying information. I can provide a dummy account if that would help (so as not to unfairly require anything of anyone else).
To Reproduce
Steps to reproduce the behavior:
- Go to URL https://www.shopback.my/survey-wall
- Click on 'Shop Now'
- An internal 'pop-up' (within the page) shows up with some marketing material and a link saying "go to survey wall now"
- Select the link (either with f or F, no difference)
- Opening the new page is blocked by Firefox
- Clicking the link with the mouse (left or middle click) both open the page in a new tab without the popup warning.
Browser and Vimium version
This behaviour is not new. These are my current versions, running on Arch Linux.
Firefox 93.0
Vimium 1.67
Additional
I have seen https://github.com/philc/vimium/issues/3539 but using Ctrl while selecting the link doesn't help.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue at https://www.shopback.my/survey-wall in Firefox 93 with Vimium 1.67, comparing keyboard selection with left- and middle-click behavior. Done means identifying why the keyboard-opened link is blocked and making it behave like the mouse activation without regressing other links.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100