Fullscreen breaks passNextKey
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
When using passNextKey command to enter fullscreen mode (e.g. on YouTube), fullscreen is entered, but Pass Next Key mode is not exited.
To Reproduce
Steps to reproduce the behavior:
- Add
map <c-]> passNextKeymapping in the settings and save it - Go to any youtube video
- Use
<c-]> f. Fullscreen is entered, however "Pass Next Key" mode remains active and can only be exited by refreshing the page.
Note: using <c-]> t works fine entering theatre mode on YouTube, as expected, so I suspect it's the fullscreen that messes it up.
Browser and Vimium version
Google Chrome | 93.0.4577.82 (Official Build) (x86_64)
OS | macOS Version 11.5.2 (Build 20G95)
Vimium | 1.67
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the listed passNextKey mapping and YouTube fullscreen steps in Chrome, then trace the passNextKey and fullscreen handling. Done means entering fullscreen with Ctrl-] followed by f exits Pass Next Key mode without requiring a page refresh; add or update a regression test if the relevant test location is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100