philc / philc/vimium

Support for React Scroll Views And Other Scrolls

Open
#3,918 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Vimium unable to scroll via React Scroll Views. It cannot identify the scrollbar as a selectable element when I press 'f' either.

Scrolling also fails with Monaco Code editor (https://microsoft.github.io/monaco-editor/playground.html). I can select the space, but not scroll properly.

Also, I do not have an example website for this but support for https://github.com/bvaughn/react-virtualized/blob/master/docs/WindowScroller.md would be hugely helpful as well! This is used by company internal search.

Thank you!! I am considering doing a pull request myself when I have time but I'm afraid I am not the best web developer.

To Reproduce
Steps to reproduce the behavior:

  1. Go to url: https://necolas.github.io/react-native-web/docs/scroll-view/
  2. Try to interact with scrollview example at the bottom of the screen (scroll bar in sandbox should not be selectable)
  3. Go to url https://microsoft.github.io/monaco-editor/playground.html
  4. You can select the window but Vimium scroll does not behave properly

Screen Shot 2021-09-20 at 11 45 53 AM

Browser and Vimium version
Google Chrome | 93.0.4577.82 (Official Build) (x86_64)
Revision | e3a25d9b9e2d0b728e045ec87c0aa4942aa46e4e-refs/branch-heads/4577@{#1237}
OS | macOS Version 11.5.2 (Build 20G95)
JavaScript | V8 9.3.345.19
User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36

Vimium v1.67

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the React Native Web ScrollView example and the Monaco Editor playground linked in the report. Investigate Vimium's handling of scrollable and selectable elements in these cases, then verify that scrolling and scrollbar selection work correctly in both examples; React Virtualized WindowScroller support is an additional reported case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.