philc / philc/vimium

[Bug] Google suggestion dropdown isn't closed when pressing `Esc`

Open
#3,917 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

Google suggestion dropdown isn't closed when pressing Esc.

To Reproduce

  • Type in search keywords in google.
  • image
  • Use Esc to close the suggestion dropdown.
  • The dropdown wasn't closed.
  • Repeat the steps in Urban Dictionary.
  • UD's suggestion dropdown can be closed.

Browser and Vimium version

Chrome: 93.0.4577.63
Vimium: 1.67

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Chrome 93 with Vimium 1.67: type search keywords on Google, press Esc, and compare the result with Urban Dictionary. Trace the keyboard handling and suggestion-dropdown interaction involved in those pages; done means pressing Esc closes Google's dropdown as it does on Urban Dictionary.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.