philc / philc/vimium

Feature Request: Chrome Dark Mode Compatability

Open
#3,916 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Hi philc,

What do you think of adding Chrome dark mode compatibility that checks if the force darkmode flag is inverting page colours? Currently the letters are getting inverted too:

Vimium Example

I imagine the overlap of vim and dark mode users is quite high.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Vimium Example shown in the issue while Chrome's force dark mode flag is enabled, then inspect the extension's rendered UI and styles to locate the inversion problem. Done means Chrome dark mode no longer inverts letters or other Vimium content incorrectly, with the behavior checked against the reported screenshot.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.