philc / philc/vimium

Entering search mode kicks you out of visual mode

Open
#3,866 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

I used to be able to enter visual mode, search for a particular string using search mode, to anchor a selection, and resume fine-tuning the selection in visual mode (i.e. I could start in visual mode, enter search mode and return to visual mode, without having to re-type 'v').

I could have imagined it, but I think I was using Vimium like this for several months before I noticed a change.

To Reproduce

Steps to reproduce the behavior:

  1. Enter visual mode (v)
  2. Enter search mode (/)
  3. Type a search string and press either return or escape (You're now kicked out of visual mode)

Browser and Vimium version

Chrome version: 91.0.4472.114
OS version: macOS Version 11.4
Vimium version: 1.67

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. First reproduce the behavior using the listed visual-mode and search-mode steps, then trace the search-mode exit handling; done means returning with either Return or Escape keeps visual mode active so selection editing can continue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.