philc / philc/vimium

Search "f" broke in chrome on most sites (tags below page instead of on top of the page)

Open
#3,827 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Since today I've noticed that the "f" search doesn't work while using chrome on:

  • Github
  • Google

For the 2 sites above, the tags are visually below the page as seen in the screenshot/gif:
image

image

Although they still do work when pressed, you cannot see what letters you have to type for what link because the results are BELOW the page instead on top of it.

It does still work on the youtube homepage, but when I press "f" while watching a video it suddenly puts the youtube video in full screen mode instead of searching (never had this before? Not sure why the behavior changed)

To Reproduce
Steps to reproduce the behavior:

  1. Type anything into google or visit ANY page on github.com and press F

Browser and Vimium version

Google Chrome 90.0.4430.212 (Officiële build) (64-bits) (cohort: Stable)
Revisie e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
Besturingssysteem Windows 10 OS Version 2009 (Build 19042.985)
JavaScript V8 9.0.257.29

Vimium Version 1.66

Side note - I've been using Vimium for at least 5 years every single day, never had issues until today. (just to show that the issue was never here and something changed to cause the issue)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the link-hint behavior with Vimium 1.66 in Chrome 90 on Windows 10, using Google, GitHub, and a YouTube video as described. Inspect the link-hint rendering and the handling of the f key; done means hints remain visible in the page viewport and f does not unexpectedly trigger fullscreen on the reported sites.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.