philc / philc/vimium

When using arrow keys to scroll, some keystrokes are ignored

Open
#3,771 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When scrolling with up and down arrow keys, some keystrokes are ignored or not processed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any page which is scrollable and does not have any scripted scrolling behavior
  2. Rapidly press the down arrow key three times
  3. Note how many times the page has scrolled (two for me)
  4. Disable Vimium completely
  5. Return to the same page
  6. Rapidly press the down arrow key three times
  7. Note that the page has scrolled three times, and is further down than after step 3

Expected
In steps 2-3 and 6-7, page has scrolled the same number of times, and the same distance.

Actual
Page only scrolls twice in steps 2-3
Page scrolls three times in steps 6-7

Notes
This bug does not reproduce reliably for me, only about half the time.
The arrow keys must be pressed rapidly in succession.
Page Up and Page Down keys are also affected.

Vimium: 1.66
Browser: Chromium Version 88.0.4324.150 (Official Build) for Linux Mint (64-bit)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the issue in Chromium with Vimium enabled and disabled, using rapid arrow, Page Up, and Page Down presses; then trace the keyboard handling involved. Done means rapid key presses scroll the same number of times and by the same distance as with Vimium disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.