philc / philc/vimium

Consider rework `g0`'s behavior: it should not jump to pinned tab

Open
#3,770 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

As we all know, currently behavior of g0 and g$ is that:

g0      go to the first "pinned" tab
g$      go to the last "unpinned" tab

There is a slightly small consistency problem here, i.e. this case: We have just one pinned tab and 500+ unpinned tabs. In case we press g0, I would expect to jump fist unpinned tab, but the actual behavior is it jumps the pinned tab. This makes a bad UX since we have to scroll all 500+ tabs in the browser to find the first tab. (May takes ~15 sec, indicates that the g0 key is not working as expected.

So what if we had 500+ pinned, 500+ unpinned tabs? I didn't think about it yet, but should we make a new keybinding for this?

g0      go to the first "unpinned" tab
g1      go to the first "pinned" tab
g$      go to the last "unpinned" tab

But this keybinding may brings an idea: "g binding count may goes to 0 to 9, maybe there never will be such a g2 binding." Consistency problems?

P.S: Pinned tabs must be just before those unpinned ones, in any browser, any environment.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names only the g0, g1, and g$ keybindings; no file, test, or entry point is provided. First trace where these tab-navigation bindings are defined, then resolve the intended pinned and unpinned behavior before determining the affected tests and what completion should verify.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.