philc / philc/vimium

Prevent <Alt+q> from being handled by Wikipedia site

Open
#3,731 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
I want Vimium to treat <Alt+q> shortcut as prevTab command and <Alt+w> as nextTab. So I define the following mappings:

map <A-q> previousTab
map <A-w> nextTab

The mappings works fine on most sites except wikipedia.org. On wikipedia, pressing <Alt+q> does switch tab as desired, but also makes wikipedia to open it's 'Special pages' which is very annoying. I think that this is because <Alt+q> is not handled by Vimium only, but also passed down to sites. Please make an option to selectively prevent <Alt+*> bindings from being handled by sites!

To Reproduce

  1. Define map <A-q> previousTab option in settings
  2. Go to URL 'https://wikipedia.org'
  3. Press <Alt+q>
  4. Now Vimium switches tabs (desired) but see also how Wikipedia opens its 'Special Pages` page (undesired)

Browser and Vimium version

OS Linux
Chromium 84.0.4147.89 (development build) (64 bits)
Vimium 1.66

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the mapped behavior on wikipedia.org with the reported mapping and confirm both tab switching and Wikipedia’s Special pages action. Then trace Vimium’s mapped-key event handling and determine how a setting could stop the site action while preserving prevTab/nextTab; done means the configured Alt mapping switches tabs without Wikipedia handling it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.