Escape key doesn't work (firefox)
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
The extension doesn't react to the escape key in any context, thus making it impossible to exit to normal mode or to cancel an action.
- press f, then press escape
- expected: hints are removed, the page goes back to normal mode
- actual: nothing happens, the page stays in the link selection mode
Same with visual selection, vomnibar, etc; escape key doesn't work in any context.
Note that the browser only receives the key UP event for the escape key, not the key down event. I wonder if that has something to do with it. I've tested it in tridactyl too, same behavior. Any ideas?
Mozilla Firefox 68.9.0esr
Vimium 1.66
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Escape-key behavior in Firefox 68.9.0esr using link selection, visual selection, and the vomnibar, then trace how Escape key events are handled. Done means Escape exits link selection and cancels actions across the reported contexts, restoring normal mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100