philc / philc/vimium

Keys using AltGr stopped working

Open
#3,691 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

I use r for reload, and / for enterFindMode. I use AltGr + r, to type a /. But on October 17 or 18, pressing AltGr + r started refreshing the page (like plain r), and not going into find mode. To see if it was an issue with Chromium, I checked with the script

  document.addEventListener('keypress', logKey);
  function logKey(e) {
      console.log(e)
  }

And Chromium recognizes my AltGr + r as /.

To Reproduce

Bind enterFindMode to some symbol you type using AltGr. And also bind something to the same key without AltGr. Press the key with AltGr. See if you enter find mode.

Browser and Vimium version

Chromium 86.0.4240.75 (Official Build) Built on Ubuntu , running on LinuxMint 19.1 (64-bit) c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}

Vimium 1.66

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Chromium on Linux with an AltGr key bound to enterFindMode and the same unmodified key bound to reload. Compare the browser's logged keypress data with Vimium's observed command, then verify that AltGr+r triggers find mode rather than reload.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.