Feature request: add to LinkHints.activateModeToOpenInNewTab the option position=end/start/after/before
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
currently, I have set
browser.tabs.insertAfterCurrent => false
browser.tabs.insertRelatedAfterCurrent => false,
so, if I use mouse to open link in tab, firefox will open new tab in the last.
bellowing are my keymap:
map f LinkHints.activateModeToOpenInNewTab
map F LinkHints.activateMode
map af LinkHints.activateModeWithQueue
but if I use "f", "F", "af" to open link, they will still open tab to the right of current tab
could you do sth like:
https://github.com/philc/vimium/pull/2895
to add option position= end/start/after/before, to LinkHints.activateModeToOpenInNewTab, LinkHints.activateMode, LinkHints.activateModeWithQueue ?
Browser and Vimium version
Firefox: 81.0.1
Vimium: 1.66
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the LinkHints.activateModeToOpenInNewTab, LinkHints.activateMode, and LinkHints.activateModeWithQueue entry points, then compare the approach in pull request 2895. Done means each command accepts position=end/start/after/before and opens the selected link in the requested tab position.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100