philc / philc/vimium

Favicons don't show up in Firefox Vomnibar

Open
#3,674 12 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When viewing the current tabs in the Vomnibar in Firefox, favicons don't show up next to the entries.

Behaviour in Firefox:

image

Expected behaviour (Chrome):

image

To Reproduce
Steps to reproduce the behavior:

  1. Open any page in Firefox
  2. Press Shift-T to open the list of current tabs in the Vomnibar.
  3. The favicon for that tab doesn't appear next to its Vomnibar entry.

This also occurs with other Vomnibar shortcuts (shift-O, shift-B...). Tried on a clean Firefox install with no tweaks to settings or additional addons, no difference.

Browser and Vimium version

Browser: Firefox 80.0.1
OS: Linux 5.4.0-48-generic #52-Ubuntu SMP (Ubuntu 20.04.1 LTS)
Vimium version: 1.66

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the missing favicon in Firefox by opening the Vomnibar with Shift-T, then check the current-tabs entry rendering and compare it with the working Chrome behavior. Verify the fix across the other mentioned shortcuts, including Shift-O and Shift-B, and confirm that favicons appear beside their entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.