philc / philc/vimium

Vomnibar does not list suggestions when triggered with o/O

Open
#3,656 8 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

When I use B,b, or T, suggestions are brought up correctly. Bookmarks for b, open tabs for T. Using o/O does not show anything as I type to vomnibar. I would expect links I have visited in history to show up.

Vimium is 1.66

Brave 1.12.112 Chromium: 84.0.4147.125 (Official Build) (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS macOS Version 10.15.6 (Build 19G73)
JavaScript V8 8.4.371.23
Flash (Disabled)
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Safari/537.36
Command Line /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --enable-features=PrefetchPrivacyChanges,AutoupgradeMixedContent,PassiveMixedContentWarning,DnsOverHttps,MixedContentSiteSetting,WebUIDarkMode,PasswordImport,ReducedReferrerGranularity --disable-features=TextFragmentAnchor,NotificationTriggers,AutofillServerCommunication,AllowPopupsDuringPageUnload,AutofillEnableAccountWalletStorage,VideoPlaybackQuality,UseButtonTranslateBubbleUI,TabHoverCards,SmsReceiver,LookalikeUrlNavigationSuggestionsUI --flag-switches-begin --flag-switches-end --enable-audio-service-sandbox
Executable Path /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the vomnibar using the B, T, and o/O triggers described, checking whether history suggestions appear while typing. Inspect the vomnibar handling for these command prefixes and compare the working bookmark and open-tab behavior with history behavior. Done means o/O lists visited-history suggestions consistently with the other triggers.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.