philc / philc/vimium

[feature request] overlap of scrollFullPageDown/scrollFullPageUp

Open
#3,601 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Vim C-F/C-B leaves some overlap between two pages to give some context while reading, Chrome's default page up/page down also has this behavior. Can we add this?

One simple solution is: if the scroll amount is large enough, we subtract a fixed/customizable value, some code like this in Scroller.scrollBy():
if (direction === "y" && elementAmount > 3 * 50) {
elementAmount -= 50;
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating and reading Scroller.scrollBy(), the entry point named in the issue, to understand how large vertical page movements are calculated. Done means scrollFullPageDown and scrollFullPageUp leave a small configurable or fixed overlap for reading context while preserving the existing behavior for smaller movements.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.