When searching, spaces are replaced with "+" instead of "%20"
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
As per the title, spaces are replaced with "+" while some websites require "%20" for space delimiters.
One example is https://www.rottentomatoes.com/search?search=alice%20in%20wonderland
To Reproduce
- Configure vimium custom search engine with
r: https://www.rottentomatoes.com/search?search=%s Rotten Tomatoes
- Search Rottentomatoes with "Alice in Wonderland"
Incorrect results given.
Brave Browser 1.8.90 and Vimium 1.66
I have a branch with a working fix for this already if this is something you guys would like addressed :)
Edit: Created a PR
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Vimium's custom search engine configuration and reproduce the Rotten Tomatoes query using the URL and steps in the issue. Verify that searching for "Alice in Wonderland" produces spaces encoded as %20 rather than +, then confirm the corrected search URL returns the expected results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 30/100