philc / philc/vimium

Firefox: Oppening a link inside a pinned tab triggers popup blocker

Open
#3,539 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Description
When I open an external link in a pinned Firefox tab using Vimium (usually using f), the link doesn't open because it triggers the popup blockers.

This is probably an interference of Vimium's js-triggered link opens and Firefox's behavior of opening external links in pinned tabs in a new tab.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure you haven't turned off Firefox's popup blocker.
  2. Pin the tab, you are viewing this issue in, using Firefox.
  3. Click this external link (Google) using f.
  4. Observe...

Browser and Vimium version
Firefox:

Version 	76.0b4
Build ID 	20200412214314

Vimium: 1.66

Edit:
I just realized that there is a workaround by pressing ctrl while clicking the link using the hint. Not ideal though since you have to conscious about it.

Edit again 😅:
I just realized that there is an even better workaround of just allowing popups for you pinned tabs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Firefox with a pinned tab, an external Google link, and Vimium's f hint action, following the listed steps. Compare the normal hint click with the documented Ctrl-click and popup-permission workarounds; done means external links from pinned tabs open without requiring either workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.