Links in Iframe shows up on link hint even out of viewport
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Links (clickable elements) in an iframe shows up on the link hint (have a link hint marker) even if they are not visible in the viewport
To Reproduce
Steps to reproduce the behavior:
- Go to any url with an iframe with buttons, like https://www.justinguitar.com/songs/eagles-hotel-california-chords-tabs-guitar-lesson-bs-624
- Scroll to the very bottom
- Press
f(to open link-hint mode) - Scroll to the top
- All the buttons in the Youtube iframe have a hint marker
Include a screenshot if applicable.
Browser and Vimium version
Firefox 73.0.1 on macOS Catalina 10.15.3
This bug matters because on some pages, there are a lot of youtube iframes but not a lot of clickable links visible at a time. This means that when I press f for link-hinking, I have to type 2 or 3 characters to select the link instead of just 1.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in Firefox using the linked JustinGuitar page: scroll to the bottom, press f, then return to the top. Start by tracing link-hint mode's handling of clickable elements inside iframes and viewport visibility. Done means offscreen iframe buttons have no hint markers while visible links remain selectable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100