philc / philc/vimium

High contrast mode on Windows labels on url hints not visible

Open
#3,511 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When high contrast mode is enabled on Windows 10, the labels on URL hints are not visible.

To Reproduce
Steps to reproduce the behavior:

  1. Enable high contrast mode
  2. Active URL hints

Include a screenshot if applicable.

image

Browser and Vimium version

  • Chromium 82 (82.0.432.3 (Official build) dev (64-bit), Windows 10 OS Version 1909 (Build 18363.657))
  • Vimium 1.65.2

I've tried overriding the styles:

div > .vimiumHintMarker span {
/* linkhint text */
color: black;
font-weight: bold;
font-size: 12px;
}

But these styles don't apply on high contrast mode. When turning off high contrast mode, the styles do get applied.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Windows 10 high contrast mode and activating Vimium URL hints. Trace the URL-hint label styles, including the shown .vimiumHintMarker span override, and verify that the labels become visible without breaking normal mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.