Labels are not clickable anymore
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
When pressing 'f' to highlight click targets, labels used to be highlighted so that you were able to select for instance custom bootstrap checkboxes (https://getbootstrap.com/docs/4.4/components/forms/#checkboxes)
Since the last version, those checkboxes are no longer selectable with vimium.
To Reproduce
Steps to reproduce the behavior:
- Go to URL: https://getbootstrap.com/docs/4.4/components/forms/#checkboxes
- Click 'f' on the keyboard
- Observe that the checkbox does not get highlighted
Before and after:
Browser and Vimium version
I've seen the bug in both Chrome and Firefox, although I don't have a specific chrome version handy at the moment.
Firefox Version: 73.0b12
Build ID 20200130174018
Vimium 1.65.0, 1.65.1, 1.65.2
(A working version of Vimium is 1.64.6)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue at the Bootstrap checkbox URL with Vimium 1.65.x, then compare its click-target highlighting behavior with version 1.64.6 in Chrome or Firefox. Trace the code path used after pressing 'f' for labels and checkboxes; done means the custom checkbox is highlighted and selectable again without breaking other click targets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100