philc / philc/vimium

Pass unhandled keys to the page

Open
#3,479 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

This is a suggestion to pass any keys that no not have a meaning to Vimium in its current state through to the page. This will minimize cases where Vimium blocks pages' native key handling.

Passing unhandled keys would be especially useful for Escape. Extra setup and keystrokes to use passNextKey would be unnecessary. In typical usage of a page with a search box, chat window, etc., Vimium would handle the first Escape to clear focus. A second escape per this suggestion would be unhandled, letting the Escape go to the page to cancel the operation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation files, tests, or entry points are named. Start by tracing Vimium's current key handling and the documented passNextKey behavior; done means keys with no current Vimium meaning reach the page without disrupting existing handled-key behavior, including the described Escape use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.