Generated link-hint label should not be exact prefix of another
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
When turning on option "use link name and characters...",
Even without the "Require Enter...",
Currently the generated hints may be a prefix of another generated hint.
e.g. my Characters used for link hints = "1234".
Generated hints may include both "3", "31", "312".
Which then forces me to click "3"+Enter if I want to click "3" - although as I said I did not turn on the "Require Enter..." option.
- This does not happen without "use link name and characters..."
To Reproduce
- Set Characters used for link hints = "123"
- Select option "use link name and characters..."
- Make sure "Require Enter..." option is not selected.
- Go to a page with many links
- Enter link-hint mode
- Some hints will be prefix of others. e.g. There will be a hint "1", but you have to click "1"+Enter, because other links are named "1?", "1??"...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue through Vimium's link-hint mode with "use link name and characters..." enabled, "Require Enter..." disabled, and characters such as "123". Trace the link-hint generation and selection entry points involved in that flow. Done means a hint is not an exact prefix of another when Enter is not required, while the reported behavior remains covered for the other option combinations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100