philc / philc/vimium

Duplicate labels generated for links that are close to each other

Open
#3,444 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Labels for links on a page are sometimes duplicated for different links. Trying to go to one of the two links fails, as the suffix after the common prefix of the two links is empty.

To Reproduce
Happened to me several times on different pages, can't find a stable way to reproduce.
This time, it was https://habr.com/ru/sandbox/start/, but, as the content on the right side is dynamic, next time the page structure may be different.

image

Here's a screen recording of the issue: https://drive.google.com/file/d/1nLHhHCdr0NYTM-P6UTFk03e52NSJAIu1/view?usp=sharing

Browser and Vimium version
Chrome Version 78.0.3904.108 (Official Build) (64-bit)
Vimium Version 1.64.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the problem on https://habr.com/ru/sandbox/start/ in Chrome with Vimium 1.64.6, using the linked screenshot and recording as reference. Trace the link-label generation entry point and confirm that nearby links receive distinct labels and that both labels successfully open their intended links.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.