philc / philc/vimium

Material buttons have two focus keys

Open
#3,396 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

If you go on angular material buttons page, you'll see that all buttons have two shortcuts associated with instead of one.

Similarly, toggle buttons are not working, see their demo.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the linked Angular Material buttons page and toggle-button demo, comparing the shortcuts shown for regular and toggle buttons. Then trace Vimium's handling of button focus and keyboard shortcuts; done means each material button has one shortcut and toggle buttons work as expected in the linked demo.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.