Vimium can't click X on certain popups.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
[Edited to clarify and crop screenshots]
Chrome version:
| Google Chrome | 74.0.3729.169 (Official Build) (64-bit) (cohort: Stable) |
|---|---|
| Revision | 78e4f8db3ce38f6c26cf56eed7ae9b331fc67ada-refs/branch-heads/3729@{#1013} |
Vimium version: 1.64.6
Pop-ups on many websites have little x's in the corner to close them. However, Vimium often can't find them and click on them.
Two examples:
To see for yourself, go to any page at the site GeeksForGeeks. Make sure you're not signed into the site, and clear any site cookies. After some browsing, a popup will appear encouraging you to sign in. No amount of "gf" and "gF" will allow me to click on the x when I press "f" or "F".
As a counterpoint, here's an example of where the x is selected properly:
Thanks for looking into this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. First reproduce the issue in Chrome on GeeksForGeeks and USA Today using the described popup conditions, then trace how Vimium discovers and selects popup close controls; done means f or F exposes and clicks the X in the reported examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100