philc / philc/vimium

Allow lowercase letter in linkhint

Open
#3,286 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

LinkHints does not honor lower case even if you specify them in the "Characters used
for link hints" option page.
I think the "linkHintNumbers = Settings.get("linkHintNumbers").toUpperCase();" in "function FilterHints" should not exist. If user specified lower case in the "Characters used
for link hints" option page, it's reasonable to assume they know what they are doing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the FilterHints function and inspect how Settings.get("linkHintNumbers") is transformed when link hints are generated. Verify the behavior with lowercase characters configured in the "Characters used for link hints" option; done means those lowercase characters are honored rather than converted to uppercase.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.