philc / philc/vimium

negative lookahead not working in regex search.

Open
#3,115 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I have enabled regex in my advanced options and some easy regex works already but this one doesn't:
in this page do this regex:
1080(?!.*x264) and you will see that it will match many things that include 1080 and x264 after it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the linked subtitle page with advanced regex enabled and the pattern 1080(?!.*x264). Start by tracing Vimium's regex search entry point and compare the matches with the intended negative-lookahead behavior; done means matches containing x264 after 1080 are excluded.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.