philc / philc/vimium

Disable DOM injection on specific site

Open
#2,997 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

When I enable vimium on google payment center, some of their function will not work at all. The reason is that they use safeHTML check to avoid potential malicious DOM manipulation. And vimium will appended a tag _vimium-has-onclick-listener to the DOM, which will break their safeHTML checking.

I tried to disable vimium on that site, but that doesn't work. Even though all the keybindings are disabled, the DOM injection still happens, so the safeHTML still breaks.

Is there a way to also disable DOM injection on specific site?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how Vimium handles site-specific disabling and where it injects the _vimium-has-onclick-listener tag. Verify the proposed behavior against the Google Payment Center URL: disabling Vimium there should prevent the DOM injection while preserving normal behavior on other sites.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.