philc / philc/vimium

mapkey: not sending the key to the page

Open
#2,996 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I recently found out that there is mapkey available.
However, it doesn't work as I expected.
For example:

mapkey q <left>
mapkey e <right>

Since there are no mapped commands for <left> and <right> in Vimium,
I expect Vimium will send the key events to the page, but it doesn't.

Would it be hard to implement this?
It may seem trivial, but I think this can be a huge improvement in Vimium's customizability.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing how the mapkey configuration handles unmapped and commands, then verify whether those mappings generate key events in the page. Done means q and e send the corresponding left and right keys when Vimium has no command for them.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.