philc / philc/vimium

Vombinar completion highlighting for protocol-full URL

Open
#2,987 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Completion highlighting works fine for protocol-less URL:
vimium-vombinar-highlighting-no-protocol

But it doesn't work for protocol-full URL (in case of Vomnibar.activateEditUrl for example):
vimium-vombinar-highlighting-https

But again works for non-http-protocols:
vimium-vombinar-highlighting-ftp

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing completion highlighting through Vomnibar.activateEditUrl with protocol-less, HTTPS, and FTP URLs, comparing the screenshots' behaviors. Trace the completion-highlighting entry point used by the Vomnibar and make protocol-full URLs highlight consistently with the working cases; done means the HTTPS case highlights correctly without regressing the others.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.