philc / philc/vimium

Hint marker text color is overwritten by other styles

Open
#2,946 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

When a website includes some style that declares things a color with the !important keyword, the letters of the link hints will be affected, potentially making them very hard to read against the background.
Therefore I suggest declaring the hint marker's text color as !important by default, which will overrride the style applied by the website.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file or test. Start by locating the hint marker styling and reproduce the problem on a page whose color rule uses !important. Done means the hint marker text color is no longer overridden by the website's color styles.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.