philc / philc/vimium

[FF] Unable to use custom navigation key mappings in Visual mode

Open
#2,873 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I shifted my navigation keys to one key right (j,k,l,ş instead of h,j,k,l) with this configuration:

unmap h
map j scrollLeft
map k scrollDown
map l scrollUp
map ş scrollRight

unmap H
map J goBack
map K previousTab
map L nextTab
map Ş goForward

However when I enter Visual mode by pressing 'v', navigation keys revert to their original bindings (h,j,k,l). Is this a bug or am I missing something obvious in my configuration?

Steps to reproduce:
  1. map scrollLeft, scrollDown, scrollUp and scrollRight commands to j, k, l and ş keys respectively like in the configuration above.(use whatever key you have next to 'l' instead of 'ş' in your keyboard)
  2. Enter Visual mode.
  3. Try using your newly mapped keys.

Browser: Firefox 57.0.1 64-bit
OS: Ubuntu 17.10 64-bit
Vimium version: Vimium 1.62

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Reproduce the custom j, k, l and adjacent-key mappings in Firefox, then enter Visual mode and compare the active bindings with normal mode. Done means the configured navigation keys work in Visual mode without reverting to h, j, k and l.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.