philc / philc/vimium

focusInput and link hints don't deal with overflow properly

Open
#2,796 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

For example, on the options page, having more exclusion rules than fit in the box gives the following.

focusInput:
screenshot from 2017-11-12 15-31-43

LinkHints.activateMode:
screenshot from 2017-11-12 15-32-14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the overflow on the options page with more exclusion rules than fit in the box, then inspect the focusInput and LinkHints.activateMode entry points named in the report. Compare both behaviors with the screenshots; done means these interfaces handle overflowing content without the reported display problem.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.