philc / philc/vimium

New version captures escape key while input sources other than English

Open
#2,768 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

With new version of Vimium, when I type <escape> in Chinese input source, the cursor will blur out the input element.

kapture 2017-11-04 at 12 33 45

Without Vimium (the old version used to work)

kapture 2017-11-04 at 12 35 36

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported behavior by typing in a Chinese input source with Vimium enabled, then compare it with Vimium disabled as shown in the issue. Trace the handling of Escape and input focus until the cause is identified; done means Escape no longer incorrectly blurs the input while the expected Vimium behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.