philc / philc/vimium

FF: page find focus issues

Open
#2,694 6 comments 10 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

There are a number of issues with Firefox and the find functionality:

  • Often when entering a string to find in Firefox the focus will briefly leave the find prompt then return with a random new selection or cursor position. Sometimes it returns to the start and this results in words entered backwards (typing "next" results in a search for "txen"), other times the whole entry is selected and then replaced when you press the next key ("nex" -> "t").
  • Sometimes the / key binding brings up Firefox's quick find prompt instead. Sometimes pressing / brings up the prompt but does not focus it at all. Pressing / again brings up quick find underneath it.
  • Ctrl+Backspace inside the find prompt does not erase any characters/words, unlike most text input fields (may not be a firefox-specific issue?)

I've found a possible reference to this so it may be a known problem but I couldn't find a relevant open issue tracking it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Firefox find-functionality behavior described in the issue and review the referenced Vimium pull request #2476. Reproduce the focus, slash-key, and Ctrl+Backspace cases in Firefox, then trace the find prompt entry point. Done means the prompt retains focus and selection correctly, slash opens it reliably, and Ctrl+Backspace behaves as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.