Vimium breaks escape/meta key in google sheets, despite excluding all keys for the site
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Reproduction
- Create a rule to exclude all vimium key bindings from google sheets.
- Edit a spreadsheet cell.
- Press ESC key.
Expected
Cell changes are cancelled and cell edit mode is terminated.
Actual
ESC key does nothing.
Notes
It seems like the ESC key is not excluded, despite an empty Exclude keys field in the rule. However, other vimium bindings are properly excluded. For example, pressing 'i' once causes a cell's contents to be replaced with the character 'i'.
Sys Info
OS X on MacBook Pro
Chrome Version 57.0.2987.133 (64-bit)
Vimium 1.59
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in Google Sheets with an exclude-all Vimium rule, then trace the key exclusion handling for the Escape key. Done means Escape cancels cell editing and exits edit mode while other Vimium bindings remain excluded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100