philc / philc/vimium

Regex search skips some matches with `n`/`N`

Open
#2,503 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

n and N will occasionally skip matches in a document. Sometimes when I test it on this page it works as usual so it's unclear as to what is causing the problem.

You can verify the below screen capture on this page.

bad-search

Search phrase: nested.loop\r

Then alternating between:

  • NN
  • nn

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the linked PostgreSQL page using nested.loop\r, alternating between NN and nn, and compare the screen capture. Then trace Vimium's regex search handling; done means these searches no longer skip matches in the document.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.