philc / philc/vimium

find mode doesn't work in Incongito mode

Open
#2,502 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Sometimes it seems that the find mode doesn't work in Incognito mode.
My environment is :
Windows 10 Home 64bit
Google Chrome v58.0.3029.81
and
Vivaldi v1.9.818.44

Reproduce :

  1. Open https://github.com/philc/vimium with Incognito mode.
  2. Hitting "/" and "vimium", it highlights "vimium" of repository name correctly.
  3. Hitting "Enter", HUD remains at the lower right of page.

Inspector shows...
2017-05-01 13 19 43

Do you have any ideas for this problem?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by opening the Vimium GitHub page in Incognito mode on Chrome or Vivaldi, then use / to search for vimium and press Enter. Inspect the lower-right HUD as shown in the linked screenshot; done means the find mode completes instead of leaving the HUD visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.